Make use of the black code formatter #33
Conversation
cbefus
left a comment
cbefus
left a comment
There was a problem hiding this comment.
Overall it seems like a pretty minimal change and will force continued consistency going forward. I am on board. Some discussion about formatting before we merge. This is also just a "for the devs" change so I wont need a version/deploy.
| value = optional.if_present(some_thing_consumer).or_else(or_else_procedure) | ||
| assert scope['if_seen'] | ||
| assert not scope['else_seen'] | ||
| value = optional.if_present(some_thing_consumer).or_else( |
There was a problem hiding this comment.
I assume we did a line break here because of the new 80 character limit? My preference would be:
value = \
optional.if_present(some_thing_consumer) \
.or_else(or_else_procedure)This formatting ensures that the readers eye always sees the indented level as directly (or as closely as possible) subbed to the item it relates.
Off this explanation I also get people on my team doing things like:
value = \
optional \
.if_present(some_thing_consumer) \
.or_else(or_else_procedure)I dont mind this, as I think it reads really easy, but something about that lone optional \ is a bit strange.
Thoughts?
There was a problem hiding this comment.
I wonder if black can be configured like this. It presents itself as an 'opinionated' formatter.
There was a problem hiding this comment.
¯_(ツ)_/¯
I could pull and try and figure it out but I am pretty impartial on linters. I can live with the above formatting if its not configurable. Curious about your preferences on the above styles though.
| optional = Optional.empty() | ||
| with pytest.raises(TestException): | ||
| optional.if_present(lambda x: x).or_else_raise(TestException("Something")) | ||
| optional.if_present(lambda x: x).or_else_raise( |
There was a problem hiding this comment.
similar comment to above about formatting.
|
|
||
| optional.if_present(some_thing_consumer).or_else_raise(ShouldNotHappenException) | ||
| assert scope['seen'] | ||
| optional.if_present(some_thing_consumer).or_else_raise( |
|
|
||
|
|
||
| CompatibleABC = ABCMeta('ABC', (object,), {'__slots__': ()}) | ||
| CompatibleABC = ABCMeta("ABC", (object,), {"__slots__": ()}) |
There was a problem hiding this comment.
I like that it prefers double quotes to single, this has always been my preference. For some reason I feel it has been historically anti-pythonic though.
There was a problem hiding this comment.
You can tell black to skip string normalization and it will leave single quoted strings as they are. It prefers doubles as text is more likely to include an apostrophe or single quote than a double quote.
dpassen
force-pushed
the
black-formatter
branch
from
d80fd54 to
e58cca2
Compare
dpassen
force-pushed
the
black-formatter
branch
from
e58cca2 to
da0c753
Compare
Worth a look.
https://black.readthedocs.io/en/stable/