Skip to content
This repository was archived by the owner on Nov 17, 2022. It is now read-only.

Conversation

@allisonnicoledeal
Copy link
Contributor

@allisonnicoledeal allisonnicoledeal commented Nov 3, 2020

Wanted to release a new updated with the new cancel_event method, which is needed for deleting input devices on the Propeller side.

I don't know what I'm doing here as far as the release goes, but wanted to start documenting..what else is needed?

Fixes https://github.com/cbsinteractive/propeller/issues/1529

@codecov
Copy link

codecov bot commented Nov 3, 2020

Codecov Report

Merging #71 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #71      +/-   ##
==========================================
+ Coverage   99.25%   99.29%   +0.03%     
==========================================
  Files           2        2              
  Lines         134      141       +7     
  Branches        8        8              
==========================================
+ Hits          133      140       +7     
  Partials        1        1              
Impacted Files Coverage Δ
elemental/client.py 99.28% <0.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1616157...9d5b8ba. Read the comment docs.

@igorsobreira
Copy link

igorsobreira commented Nov 4, 2020

@allisonnicoledeal I believe we need to build first:

poetry build
poetry publish

or

poetry publish --build

https://python-poetry.org/docs/cli/#publish

@igorsobreira
Copy link

@allisonnicoledeal just realized we have a makefile, here is an idea:

release: clean-build
    poetry publish --build

I haven't tried yet 🙂

@rafaelcaricio
Copy link
Contributor

That is basically it. Later we can create a user in PyPI just for publishing releases and create a Github workflow to do it automatically based on tags. #74

@allisonnicoledeal
Copy link
Contributor Author

@allisonnicoledeal just realized we have a makefile, here is an idea:

release: clean-build
    poetry publish --build

I haven't tried yet 🙂

Success! 9d5b8ba

@allisonnicoledeal allisonnicoledeal merged commit 7a1ac22 into master Nov 4, 2020
@allisonnicoledeal allisonnicoledeal deleted the bump-version branch November 4, 2020 18:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants