Skip to content

Support breaking syntax changes in bs-platform 7.1.0 / reason latest #41

@jchavarri

Description

@jchavarri

In most recent version 7.1.0, BuckleScript also updated to the latest version of Reason parser, which included a change to the way bs.obj externals are declared, making the empty string optional: reasonml/reason#2464.

To add to that, refmt now picks the option of removing the empty string by default with no way to configure that. So when we ran bsrefmt through our codebase, all empty strings from bs.obj externals were removed.

This situation breaks bs-react-intl-extractor because bs.obj without strings was legitimately not valid syntax in Reason 3.5.2, the version of the parser that bs-react-intl-extractor is currently using.

Probable fix involves just updating dep to latest:
https://github.com/cknitt/bs-react-intl-extractor/blob/3aa00958695881ac9ea116a5fddd4fd2b457f27e/package.json#L26

But unfortunately there's been no new release for @esy-ocaml/reason in npm, so I guess a resolution can be used for esy to pick the right version?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions