Skip to content

Commit 9311b90

Browse files
committed
Address PR comments
1 parent f752dee commit 9311b90

File tree

2 files changed

+14
-19
lines changed

2 files changed

+14
-19
lines changed

examples/Page.re

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
open ReactIntl;
12
open PageLocale;
23

34
[@react.component]
@@ -17,19 +18,19 @@ let make = (~locale, ~setLocale) => {
1718
</button>
1819
</div>
1920
<div className="message">
20-
<ReactIntl.FormattedMessage id="page.hello" defaultMessage="Hello" />
21+
<FormattedMessage id="page.hello" defaultMessage="Hello" />
2122
" "->React.string
22-
<ReactIntl.FormattedMessage id="page.world" defaultMessage="World" />
23+
<FormattedMessage id="page.world" defaultMessage="World" />
2324
</div>
2425
<div>
25-
ReactIntl.(intl->Intl.formatMessage(pageLocale##today)->React.string)
26+
{intl->Intl.formatMessage(pageLocale##today)->React.string}
2627
" "->React.string
27-
ReactIntl.(intl->Intl.formatDate(Js.Date.make())->React.string)
28+
{intl->Intl.formatDate(Js.Date.make())->React.string}
2829
" (intl.formatDate)"->React.string
2930
<br />
30-
ReactIntl.(intl->Intl.formatMessage(pageLocale##today)->React.string)
31+
{intl->Intl.formatMessage(pageLocale##today)->React.string}
3132
" "->React.string
32-
<ReactIntl.FormattedDate value={Js.Date.make()} />
33+
<FormattedDate value={Js.Date.make()} />
3334
" (FormattedDate)"->React.string
3435
</div>
3536
</div>;

examples/Util.re

Lines changed: 7 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,14 @@
1-
let wrapUnicodeString = (input: string) => {j|$input|j};
2-
3-
let wrapOptUnicodeString = (input: Js.nullable(string)) =>
4-
switch (input->Js.Nullable.toOption) {
5-
| Some(input) => input->wrapUnicodeString
6-
| None => ""
7-
};
8-
91
let translationsToDict = (translations: array(ReactIntl.translation)) => {
102
translations->Belt.Array.reduce(
113
Js.Dict.empty(),
12-
(dict, message) => {
13-
let unicodeMessage = message##message->wrapOptUnicodeString;
14-
let unicodeDefaultMessage = message##defaultMessage->wrapUnicodeString;
4+
(dict, entry) => {
155
dict->Js.Dict.set(
16-
message##id,
17-
unicodeMessage !== "" ? unicodeMessage : unicodeDefaultMessage,
6+
entry##id,
7+
switch (entry##message->Js.Nullable.toOption) {
8+
| None
9+
| Some("") => entry##defaultMessage
10+
| Some(message) => message
11+
},
1812
);
1913
dict;
2014
},

0 commit comments

Comments
 (0)