Skip to content

Fix label behavior for frame options #1587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2025
Merged

Fix label behavior for frame options #1587

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 13 additions & 10 deletions media/src/objects/Curve.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@
Z.evaluate({ t, a: aVal }),
),
);
$inspect(xyz);
// $inspect(xyz);

$effect(() => {
// console.log('effex in framez');
Expand Down Expand Up @@ -279,6 +279,8 @@
osculatingCircle: false,
});

// $inspect(vizOptions);

$effect(() => {
frame.visible = vizOptions.frame;
arrows.r.visible = vizOptions.pos;
Expand Down Expand Up @@ -430,7 +432,7 @@

// Runs the update if math expression "params" has a dependence on 'a'
let isDynamic = $derived(dependsOn(params, 'a'));
$inspect(isDynamic);
// $inspect(isDynamic);

// Start animating if animation changes (e.g. animating scene published)
// Two ifs because one reacts only to animation changing and the other
Expand Down Expand Up @@ -742,37 +744,38 @@

<span class="box-1">Frame</span>
<span class="box box-2" id="frameSwitches">
<label class="switch" for="frameVisible">
<label class="switch">
<input
type="checkbox"
name="frameVisible"
id="frameVisible"
name="frameVis"
id="frameVis"
bind:checked={vizOptions.frame}
/>
<span class="slider round"></span>
</label>
{#if vizOptions.frame}
<label for="framPos"
<label
><M size={'sm'} s="\\mathbf r" />
<input
type="checkbox"
name="framePos"
id="framePos"
bind:checked={vizOptions.pos}
/>
</label>
<label for="framevel">
<label>
<M size={'sm'} s={"\\mathbf r'"} />
<input
type="checkbox"
name="framevel"
name="frameVel"
bind:checked={vizOptions.vel}
/>
</label>
<label for="frameacc"
<label
><M size="sm" s={"\\mathbf r''"} />
<input
type="checkbox"
name="frameacc"
name="frameAcc"
bind:checked={vizOptions.acc}
/>
</label>
Expand Down