Use '' for default CAS_DEFAULT_NEXT setting #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves an issue with new CAS server. The 'next' param needs to be the same as in the CAS input form. I'm not sure why this weird param was added as a default here, but I'm able to log in on CAS on both the front page, and the admin form, on mediathread-staging with this change. As Dan mentioned, we eventually want to clean this up (change 'destination' to 'TARGET' on the log in form). Making that change broke the login for me, so I'm keeping that as is at the moment. That's in mediathread_deploy_specific, btw.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves an issue with new CAS server. The 'next' param
needs to be the same as in the CAS input form. I'm not sure why this
weird param was added as a default here, but I'm able to log in on CAS
on both the front page, and the admin form, on mediathread-staging with
this change.
As Dan mentioned, we eventually want to clean this up (change
'destination' to 'TARGET' on the log in form). Making that change broke
the login for me, so I'm keeping that as is at the moment. That's in
mediathread_deploy_specific, btw.