REF run.sh: no need for bash, no need for export #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hound shouldn't be ran from the makefile, but rather it has to be ensured that hound exists before being ran, in the shell script. That way it is more logical, and people only have to type `./run.sh`
Also, when creating a file with a rule, it is a good practice to make the rule named after that file, so make can ensure it is up to date.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/bin/bashisn't POSIX,/bin/shis. Since there is no need for bashstrictly speaking, using a POSIX sh shell in the shebang is much more
portable.
In addition, the export keywords were useless since it is possible to
set the variables much in the same way for that binary only (with the
additional benefit of not leaking variables in any shell).