Skip to content

fix: Skip invocation of hooks and unzip / delete commands if no hooks are registered #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 5, 2024
Merged

fix: Skip invocation of hooks and unzip / delete commands if no hooks are registered #259

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/private/bundling.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ export class Bundling implements cdk.BundlingOptions {
: cdk.AssetHashType.SOURCE,
exclude: ['**/bin/', '**/obj/'],
bundling: {
outputType: cdk.BundlingOutput.AUTO_DISCOVER,
image: bundling.image,
command: bundling.command,
environment: bundling.environment,
Expand Down Expand Up @@ -164,6 +165,12 @@ export class Bundling implements cdk.BundlingOptions {
]
.filter((c) => !!c)
.join(' ');

// Skip invocation of hooks and unzip / delete commands if no hooks are registered
if (!this.props.commandHooks) {
return dotnetPackageCommand;
}

const unzipCommand: string =
osPlatform === 'win32'
? [
Expand All @@ -182,11 +189,11 @@ export class Bundling implements cdk.BundlingOptions {
: ['rm', packageFile].filter((c) => !!c).join(' ');

return chain([
...(this.props.commandHooks?.beforeBundling(inputDir, outputDir) ?? []),
...(this.props.commandHooks.beforeBundling(inputDir, outputDir) ?? []),
dotnetPackageCommand,
unzipCommand,
deleteCommand,
...(this.props.commandHooks?.afterBundling(inputDir, outputDir) ?? []),
...(this.props.commandHooks.afterBundling(inputDir, outputDir) ?? []),
]);
}
}
Expand Down