feat: allow users to customize alarm annotation properties #184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
voho
force-pushed
the
vojta-customannotations
branch
from
a6c70ec to
c08ff07
Compare
ghost
reviewed
Jun 30, 2022
ghost
reviewed
Jul 4, 2022
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
Can you add some tests to AlarmFactory.test.ts as well?
Otherwise, LGTM.
Contributor
Author
Sure, will do. Thanks. |
voho
force-pushed
the
vojta-customannotations
branch
from
56a2bf7 to
2c05318
Compare
ghost
approved these changes
Jul 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow users to override 1) color 2) label 3) visibility of the alarm annotation.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license