fix: consolidate messages for unpublished packages #1761
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iankhou
reviewed
Jul 14, 2025
| } | ||
| } | ||
|
|
||
| for (const version of unpublishedVersions) { |
There was a problem hiding this comment.
This will still result in a single log per version. You'll need to concat the messages into a single INFO log to reduce the number of logs.
iankhou
requested changes
Jul 14, 2025
iankhou
approved these changes
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently send a message per unpublished version. However, a package that has many versions unpublished will pollute the logs with many messages. This PR consolidates those messages into one message that can be collapsed so that the logs are much easier to parse.
No tests; this only affects logging
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license