Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/__tests__/__snapshots__/construct-hub.test.ts.snap

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/__tests__/devapp/__snapshots__/snapshot.test.ts.snap

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 12 additions & 3 deletions src/package-sources/npmjs/npm-js-follower.lambda.ts
Original file line number Diff line number Diff line change
Expand Up @@ -529,16 +529,15 @@ function getRelevantVersionInfos(
Unit.Count
);

const unpublishedVersions: string[] = [];
for (const [version, modified] of packageVersionUpdates) {
const knownKey = `${change.doc.name}@${version}`;
const known = knownVersions.get(knownKey);
if (known == null || known < modified) {
const infos = change.doc.versions[version];
if (infos == null) {
// Could be the version in question was un-published.
console.log(
`[${change.seq}] Could not find info for "${change.doc.name}@${version}". Was it un-published?`
);
unpublishedVersions.push(knownKey);
} else if (isConstructLibrary(infos)) {
// skip if this package is denied
const denied = denyList.lookup(infos.name, infos.version);
Expand Down Expand Up @@ -579,6 +578,16 @@ function getRelevantVersionInfos(
// Else this is not a construct library, so we'll just ignore it...
}
}

if (unpublishedVersions.length > 0) {
console.log(
`[${
change.seq
}] Could not find info for the following versions. Were they un-published?\n${unpublishedVersions.join(
',\n'
)}`
);
}
}
return result;

Expand Down