feat: reduce assembly size #567
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 18, 2021 08:38
Delete the `types` field from `assembly.json` to reduce size. For example, for `aws-cdk-lib`, this reduces the size of the assembly from 33.1MiB to 1.1MiB. This field is not being used by the client (API docs are generated in the backend). Resolves cdklabs/construct-hub-webapp#691
iliapolo
approved these changes
Nov 18, 2021
iliapolo
pushed a commit
that referenced
this pull request
Nov 18, 2021
Delete the `types` field from `assembly.json` to reduce size. For example, for `aws-cdk-lib`, this reduces the size of the assembly from 33.1MiB to 1.1MiB. This field is not being used by the client (API docs are generated in the backend). Resolves cdklabs/construct-hub-webapp#691 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
eladb
pushed a commit
that referenced
this pull request
Nov 18, 2021
As a follow up to #567, delete additional large fields from `assembly.json` that are not used by the client. Namely: `readme` and `dependencyClosure`. Related to cdklabs/construct-hub-webapp#691
mergify bot
pushed a commit
that referenced
this pull request
Nov 18, 2021
As a follow up to #567, delete additional large fields from `assembly.json` that are not used by the client. Namely: `readme` and `dependencyClosure`. Related to cdklabs/construct-hub-webapp#691 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete the
typesfield fromassembly.jsonto reduce size. For example, foraws-cdk-lib, this reduces the size of the assembly from 33.1MiB to 1.1MiB.This field is not being used by the client (API docs are generated in the backend).
Resolves cdklabs/construct-hub-webapp#691
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license