Skip to content

Conversation

@merceyz
Copy link
Member

@merceyz merceyz commented Feb 3, 2018

This PR solves the issue described in #2206 (comment)

The changes in this PR prevents the designer from setting the default value of specific properties which caused it to attempt to load CefSharp.Core causing an exception to be thrown

@merceyz merceyz added this to the 63.0.0 milestone Feb 3, 2018
@AppVeyorBot
Copy link

@amaitland
Copy link
Member

Should we do the same with other properties like BrowserSettings?

@amaitland amaitland merged commit 456ec8b into cefsharp:master Feb 5, 2018
@merceyz
Copy link
Member Author

merceyz commented Feb 5, 2018

We could but we don't have to. These were the only ones causing a issue.

If you add a control to a form the designer adds this code, so these would be the ones to add it to

this.chromiumWebBrowser1.BrowserSettings = null;
this.chromiumWebBrowser1.DialogHandler = null;
this.chromiumWebBrowser1.DisplayHandler = null;
this.chromiumWebBrowser1.DownloadHandler = null;
this.chromiumWebBrowser1.DragHandler = null;
this.chromiumWebBrowser1.FindHandler = null;
this.chromiumWebBrowser1.FocusHandler = null;
this.chromiumWebBrowser1.GeolocationHandler = null;
this.chromiumWebBrowser1.IsActivating = false;
this.chromiumWebBrowser1.JsDialogHandler = null;
this.chromiumWebBrowser1.KeyboardHandler = null;
this.chromiumWebBrowser1.LifeSpanHandler = null;
this.chromiumWebBrowser1.LoadHandler = null;
this.chromiumWebBrowser1.MenuHandler = null;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants