Use Begin/End pattern to not break .Net 4 compatibility.

[bjarteskogoy]

No description provided.

[amaitland]

Remove commented out Contract

[amaitland]

I'm wondering if it's worth detecting the .Net framework version and using the Begin/End approach as a fallback option.

As per http://msdn.microsoft.com/en-us/library/hh925568%28v=vs.110%29.aspx we can check the registry to see what version is installed. (There is a fairly simple example near the bottom of the page)

Idea raises a couple of questions

• Am I over thinking things?
• Does checking the registry require any additional security rights that previously weren't required?
• Should KISS be applied?

Thoughts?

[bjarteskogoy]

Would there be any benefits of the Task<> approach over Begin/End performance-wise?
If not I don't see any good reasons for that, as long as the developer anyway is exposed to the methods returning Tasks; https://github.com/bjarteskogoy/CefSharp/blob/JsBinding_WIP/CefSharp.Wpf/ChromiumWebBrowser.cs#L1133 and https://github.com/bjarteskogoy/CefSharp/blob/JsBinding_WIP/CefSharp.Wpf/ChromiumWebBrowser.cs#L1138.

[amaitland]

Unsure about the perf benefits, it just seems a step backwards! It just offends my sense of aesthetics! lol

I'm probably over thinking it 😄

[bjarteskogoy]

:)

[peters]

@amaitland I agree, it looks awful :(

[JanEggers]

hi guys why do we need this ?

task is .net 4.0 compatible you just need to use continue on the task instead of await.

did i miss something ?

[amaitland]

@JanEggers Apparently it's a Task/WCF thing in pure .Net 4.0. The error reported is in #490

"Unhandled exception with message Type 'System.Threading.Tasks.Task`1[CefSharp.JavascriptResponse]' cannot be serialized. Consider marking it with the DataContractAttribute attribute, and marking all of its members you want serialized with the DataMemberAttribute attribute. If the type is a collection, consider marking it with the CollectionDataContractAttribute. See the Microsoft .NET Framework documentation for other supported types.. "

More suggestions on solutions are most welcome 😄

[JanEggers]

ouch i wasnt aware of that.

no idea on my side

[amaitland]

We can still use Task, just have to wrap old style Begin/End Async calls on the WCF interface.

Looks ugly, it's a viable solution though. Can always improve it later if someone comes up with a brilliant idea.

[amaitland]

I have reviewed this, I'll make one minor formatting change after it's merged, apart from that thanks for the fantastic contribution @bjarteskogoy merging now 😄