Skip to content

niza/fox-rule-crashing-for-vendor-files #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 15, 2023
Merged

niza/fox-rule-crashing-for-vendor-files #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/SpatieLaravelData/Rules/ValidTypeRule.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,8 @@ public function processNode(Node $node, Scope $scope): array
// Flatten from a list of calls pr. file, to just a list of calls.
->flatten(1)
->map(Call::unserialize(...))
// Make sure the rule does not crash in case a specific data class has not been analyzed - This can happen with data classes in the vendor folder
->filter(fn (Call $call) => isset($classCollector[$call->target]))
// Check each call for errors
->map(fn (Call $call) => $this->compareTypes($call, $castCollector, $classCollector[$call->target]))
// Flatten from a list of errors pr. call, to just a list of errors.
Expand Down