Skip to content

Conversation

@matusvalo
Copy link
Member

This branch fixes issues with unittests and now all unittests are passing (in python3 and python 2.7) - see below. Moreover one issue is fixed found by unittests - conneciton._declare_queue() was returning bytes instead of string in python3.

$ python setup.py test
running build
running build_py
running build_ext
running test
running egg_info
writing top-level names to librabbitmq.egg-info/top_level.txt
writing requirements to librabbitmq.egg-info/requires.txt
writing librabbitmq.egg-info/PKG-INFO
writing dependency_links to librabbitmq.egg-info/dependency_links.txt
reading manifest file 'librabbitmq.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
warning: no files found matching '*' under directory 'tests'
no previously-included directories found matching '*.pyc'
no previously-included directories found matching '*.o'
no previously-included directories found matching '*.la'
no previously-included directories found matching '*.so'
no previously-included directories found matching '*.dylib'
writing manifest file 'librabbitmq.egg-info/SOURCES.txt'
running build_ext
copying build/lib.linux-x86_64-3.5/_librabbitmq.cpython-35m-x86_64-linux-gnu.so ->
test_basic_get_ack (librabbitmq.tests.test_functional.test_Channel) ... ok
test_send_message (librabbitmq.tests.test_functional.test_Channel) ... ok
test_timeout (librabbitmq.tests.test_functional.test_Channel)
Check that our ``drain_events`` call actually times out if ... ok
test_timeout_burst (librabbitmq.tests.test_functional.test_Channel)
Check that if we have a large burst of messages in our queue ... ok
test_delete (librabbitmq.tests.test_functional.test_Delete)
Test that we can declare a channel delete it, and then declare with ... ok
test_delete_empty (librabbitmq.tests.test_functional.test_Delete)
Test that the queue doesn't get deleted if it is not empty ... ok

----------------------------------------------------------------------
Ran 6 tests in 0.216s

OK

# python setup.py test
/opt/rh/rh-python35/root/usr/lib64/python3.5/distutils/dist.py:261: UserWarning: Unknown distribution option: 'build_requires'
  warnings.warn(msg)
/auto/home/homeb/d56032/envs/librabbitmq35/lib64/python3.5/site-packages/setuptools/dist.py:294: UserWarning: The version specified ('DEV') is an invalid version, this may not work as expected with newer versions of setuptools, pip, and PyPI. Please see PEP 440 for more details.
  "details." % self.metadata.version
running test
running egg_info
writing dependency_links to librabbitmq_funtests.egg-info/dependency_links.txt
writing librabbitmq_funtests.egg-info/PKG-INFO
writing top-level names to librabbitmq_funtests.egg-info/top_level.txt
reading manifest file 'librabbitmq_funtests.egg-info/SOURCES.txt'
writing manifest file 'librabbitmq_funtests.egg-info/SOURCES.txt'
running build_ext
test_channel_replaced_on_exception (funtests.tests.test_channel_errors.test_channel_failures) ... ok

Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems ok to me. do you have any other inputs?

@matusvalo
Copy link
Member Author

For now not. Maybe later I will add more unittest but for now python 3 migration should be done. If new issues will pop out I will fix them.

@auvipy auvipy merged commit 5f4e901 into celery:master Oct 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants