Skip to content

Conversation

@merutak
Copy link

@merutak merutak commented Aug 17, 2017

my tests show that this solves #97

Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible for you to add some test/do some test for this pr?

@merutak
Copy link
Author

merutak commented Nov 11, 2017

@auvipy I wouldn't hold my breath :/ For now I couldn't even get it to compile on my machine (there are several (closed) tickets about Ubuntu/Debian compilation difficulties, I ran into them).
Also I'm not sure how to write the test using Python wrappers. The test should go something like this, if somebody can get to do it:
Scenario 1: Client opens two channels. Client sends a valid message on each channel, but makes sure to first send just the method (on each channel) and then the rest. Without the fix, this is expected to fail.
Scenario 2: Client opens two channels. Client sends a method + header on one channel, and then method+header+contents on the other channel. (And then completes the first message). This is also expected to fail without the fix.

What do you think?

@auvipy auvipy merged commit 5b9bf23 into celery:master Jan 15, 2018
@auvipy
Copy link
Member

auvipy commented Jan 15, 2018

it's better to use pyamqp as thats more maintained

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants