Skip to content

Cleanup #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Cleanup #163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions src/pytest_celery/api/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,19 +145,6 @@ def create_setup_app(cls, celery_setup_config: dict, celery_setup_app_name: str)

return app

def chords_allowed(self) -> bool:
# TODO: Possibly a not relevant
try:
self.app.backend.ensure_chords_allowed()
except NotImplementedError:
return False

# TODO: Possibly a bug
if any([v.startswith("4.") for v in self.worker_cluster.versions]):
return False

return True

def teardown(self) -> None:
"""Teardown the setup."""

Expand Down
4 changes: 0 additions & 4 deletions tests/smoke/test_canvas.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
from __future__ import annotations

import pytest
from celery.canvas import chain
from celery.canvas import chord
from celery.canvas import group
Expand Down Expand Up @@ -69,9 +68,6 @@ def test_chain(self, celery_setup: CeleryTestSetup):

def test_chord(self, celery_setup: CeleryTestSetup):
worker: CeleryTestWorker
if not celery_setup.chords_allowed():
pytest.skip("Chords are not supported")

for worker in celery_setup.worker_cluster:
queue = worker.worker_queue

Expand Down