ENT-3761: Upgrade php 7.2.5 and fix rhel5 php problems #370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vpodzime
reviewed
Apr 27, 2018
Contributor
vpodzime
left a comment
vpodzime
left a comment
There was a problem hiding this comment.
The patch should be in the php subfolder as it is php-specific.
Contributor
Author
|
Odd. I thought I had put it there. Will fix. |
craigcomstock
force-pushed
the
upgrade-php-7.2.5
branch
from
04ff1cb to
88dcfa3
Compare
Contributor
Author
|
Ok. Squashed and will test again before merging. |
Contributor
Author
|
just to be safe, I'm going to only fix the issue and not upgrade php. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
option #2, upgrade php and fix rhel5 build problem for php