ENT-10962: Fixed mission portal restoring changes from /var/cfengine/share/GUI #2796

nickanderson · 2023-12-12T18:16:39Z

No description provided.

craigcomstock

sweet.

nickanderson · 2023-12-12T18:53:03Z

@cf-bottom jenkins, please.

cf-bottom · 2023-12-12T18:53:45Z

Sure, I triggered a build:

Jenkins: https://ci.cfengine.com/job/pr-pipeline/10154/

Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-10154/

nickanderson · 2023-12-15T20:07:06Z

@cf-bottom jenkins, please.

cf-bottom · 2023-12-15T20:08:39Z

Sure, I triggered a build:

Jenkins: https://ci.cfengine.com/job/pr-pipeline/10184/

Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-10184/

craigcomstock · 2023-12-18T14:28:40Z

sequential-test failed due to missing cf-support not being able to process core dumps on ubuntu 20 apparently. I will fix in ENT-11106.

craigcomstock · 2023-12-18T14:29:14Z

acceptance-test problem here was a publishing error for release-data which was fixed last week so I have re-run that job here.

craigcomstock · 2023-12-18T14:59:57Z

The no-noise failure in sequential-tests maybe is a flake with aws ubuntu repos not being available? Logged a ticket: ENT-11107

So I think your PR is good to go.

nickanderson · 2024-01-05T16:08:33Z

@cf-bottom jenkins, please.

cf-bottom · 2024-01-05T16:08:46Z

Alright, I triggered a build:

Jenkins: https://ci.cfengine.com/job/pr-pipeline/10255/

Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-10255/

nickanderson · 2024-01-09T15:59:27Z

@cf-bottom jenkins, please.

cf-bottom · 2024-01-09T16:03:50Z

Alright, I triggered a build:

Jenkins: https://ci.cfengine.com/job/pr-pipeline/10264/

Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-10264/

cf-bottom · 2024-01-11T14:54:23Z

Sure, I triggered a build:

Jenkins: https://ci.cfengine.com/job/pr-pipeline/10268/

Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-10268/

craigcomstock · 2024-01-11T14:57:04Z

made a ticket for your sequential-tests failure, maybe it is a flake? https://northerntech.atlassian.net/browse/ENT-11182

craigcomstock · 2024-01-12T16:45:29Z

trying sequential-tests again, we'll see if the build packages are still available to use

Like the existing no_backup_cp this copy_from body is used to copy files locally without making backups but with the additional ability to specify the comparison used. Ticket: ENT-10962 Changelog: commit

…hen modified Prior to this change if Mission Portal application code was modified it would not be returned to the packaged state because the deployed code would have a newer timestamp than the packaged source. This change switches to using binary comparison of Mission Portal to it's packaged source to determine if the deployed application should be reverted. Ticket: ENT-10962 Changelog: Title

nickanderson · 2024-01-24T21:05:20Z

@cf-bottom jenkins, please.

cf-bottom · 2024-01-24T21:08:30Z

Alright, I triggered a build:

Jenkins: https://ci.cfengine.com/job/pr-pipeline/10321/

Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-10321/

nickanderson · 2024-01-25T19:10:32Z

@craigcomstock this is failing FR distributed cleanup and bootstrap tests, should we go ahead and merged (I know you already approved but I don't want to make new CI problems.

Bootstrap failed in relation to log permission change:

20:04:25 Permission or ownership changes in normal agent run!
20:04:25 + grep -Pi 'info: (Group of|Owner of|.*had permission)' .25595.normal.log
20:04:25 34.240.57.64	    info: Regular file '/var/cfengine/httpd/logs/application/./log-2024-01-25.log' had permissions 0644, changed it to 0600
20:04:25 + fail_test 1
20:04:25 + failure

And FR maybe had issues with SSH?

20:13:52 Q: ".../bin/bash /opt/": 18.201.124.65
20:13:52 Q: ".../bin/bash /opt/": Permission denied (publickey).
20:13:52 Q: ".../bin/bash /opt/": [Thu Jan 25 02:13:52 UTC 2024] Trying fallback dump directory /opt/cfengine/federation//cftransport/source. Upgrade masterfiles on feeder to enable multiple superhubs pulling from one feeder.
20:13:52 Q: ".../bin/bash /opt/": Permission denied (publickey).
20:13:52 Q: ".../bin/bash /opt/": [Thu Jan 25 02:13:52 UTC 2024] Trying fallback dump directory /opt/cfengine/federation//cftransport/source. Upgrade masterfiles on feeder to enable multiple superhubs pulling from one feeder.
20:13:52 Q: ".../bin/bash /opt/": Permission denied (publickey).
20:13:52 Q: ".../bin/bash /opt/": [Thu Jan 25 02:13:52 UTC 2024] Trying fallback dump directory /opt/cfengine/federation//cftransport/source. Upgrade masterfiles on feeder to enable multiple superhubs pulling from one feeder.
20:13:52 Q: ".../bin/bash /opt/": Permission denied (publickey).
20:13:52 Q: ".../bin/bash /opt/": [Thu Jan 25 02:13:52 UTC 2024] Trying fallback dump directory /opt/cfengine/federation//cftransport/source. Upgrade masterfiles on feeder to enable multiple superhubs pulling from one feeder.
20:13:52 Q: ".../bin/bash /opt/": Permission denied (publickey).
20:13:52 Q: ".../bin/bash /opt/": [Thu Jan 25 02:13:52 UTC 2024] No files to transport.
20:13:52 Q: ".../bin/bash /opt/": Permission denied (publickey).
20:13:52 Q: ".../bin/bash /opt/": [Thu Jan 25 02:13:52 UTC 2024] No files to transport.
20:13:52 Q: ".../bin/bash /opt/": Permission denied (publickey).
20:13:52 Q: ".../bin/bash /opt/": [Thu Jan 25 02:13:52 UTC 2024] No files to transport.
20:13:52 Q: ".../bin/bash /opt/": Permission denied (publickey).
20:13:52 Q: ".../bin/bash /opt/": [Thu Jan 25 02:13:52 UTC 2024] No files to transport.
20:13:52 Q: ".../bin/bash /opt/": Permission denied (publickey).
20:13:52 Q: ".../bin/bash /opt/": [Thu Jan 25 02:13:52 UTC 2024] Trying fallback dump directory /opt/cfengine/federation//cftransport/source. Upgrade masterfiles on feeder to enable multiple superhubs pulling from one feeder.
20:13:52 Q: ".../bin/bash /opt/": Permission denied (publickey).

craigcomstock · 2024-01-26T14:17:55Z

distributed cleanup ssl failure is known https://northerntech.atlassian.net/browse/ENT-11215
cf-support timeout after failure is known https://northerntech.atlassian.net/browse/ENT-10486

seems you could go ahead and merge 👍

nickanderson requested a review from craigcomstock December 12, 2023 18:17

craigcomstock approved these changes Dec 12, 2023

View reviewed changes

nickanderson force-pushed the ENT-10962/master branch from 7ea901a to dd91713 Compare December 15, 2023 19:45

nickanderson force-pushed the ENT-10962/master branch from dd91713 to d03e93c Compare January 5, 2024 16:08

nickanderson force-pushed the ENT-10962/master branch from d03e93c to 615fe78 Compare January 9, 2024 15:59

nickanderson added 2 commits January 24, 2024 15:04

Added no_backup_cp_compare copy_from body to stdlib

fcc64a6

Like the existing no_backup_cp this copy_from body is used to copy files locally without making backups but with the additional ability to specify the comparison used. Ticket: ENT-10962 Changelog: commit

nickanderson force-pushed the ENT-10962/master branch from 615fe78 to d37dedd Compare January 24, 2024 21:05

nickanderson added the cherry-pick? Fixes which may need to be cherry-picked to LTS branches label Feb 1, 2024

nickanderson merged commit 9457a84 into cfengine:master Feb 1, 2024

This was referenced May 24, 2024

ENT-10962: Fixed mission portal restoring changes from /var/cfengine/share/GUI (3.18) #2892

Merged

ENT-10962: Fixed mission portal restoring changes from /var/cfengine/share/GUI (3.21) #2891

Merged

olehermanse removed the cherry-pick? Fixes which may need to be cherry-picked to LTS branches label May 27, 2024

ENT-10962: Fixed mission portal restoring changes from /var/cfengine/share/GUI #2796

ENT-10962: Fixed mission portal restoring changes from /var/cfengine/share/GUI #2796

Uh oh!

Conversation

nickanderson commented Dec 12, 2023

Uh oh!

craigcomstock left a comment

Choose a reason for hiding this comment

Uh oh!

nickanderson commented Dec 12, 2023

Uh oh!

cf-bottom commented Dec 12, 2023

Uh oh!

nickanderson commented Dec 15, 2023

Uh oh!

cf-bottom commented Dec 15, 2023

Uh oh!

craigcomstock commented Dec 18, 2023

Uh oh!

craigcomstock commented Dec 18, 2023

Uh oh!

craigcomstock commented Dec 18, 2023

Uh oh!

nickanderson commented Jan 5, 2024

Uh oh!

cf-bottom commented Jan 5, 2024

Uh oh!

nickanderson commented Jan 9, 2024

Uh oh!

cf-bottom commented Jan 9, 2024

Uh oh!

cf-bottom commented Jan 11, 2024

Uh oh!

craigcomstock commented Jan 11, 2024

Uh oh!

craigcomstock commented Jan 12, 2024

Uh oh!

nickanderson commented Jan 24, 2024

Uh oh!

cf-bottom commented Jan 24, 2024

Uh oh!

nickanderson commented Jan 25, 2024

Uh oh!

craigcomstock commented Jan 26, 2024

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants