Follow up for FR SSH SELinux context fixes #2817
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craigcomstock
approved these changes
Jan 2, 2024
Contributor
craigcomstock
left a comment
craigcomstock
left a comment
There was a problem hiding this comment.
I don't see why we couldn't back port these changes. A nice refactoring. 👍
We need to make sure both `semanage fcontext -a` and `restorecon`
are done before we run `ssh-keygen`. Otherwise `ssh-keygen` may
be blocked by SELinux when trying to save/write the generated
key at first and only succeeds in a later agent run.
Ticket: ENT-11136
Changelog: Federated reporting policy fixes SELinux context of
the ~cftransport/.ssh directory and its contents in a
single agent run.
vpodzime
force-pushed
the
master-FR_selinux_fixes_fwup
branch
from
938f549 to
ff392a9
Compare
vpodzime
added
the
cherry-pick?
craigcomstock
removed
the
cherry-pick?
Contributor
|
I removed the cherry-pick label because we decided these changes were too disruptive. |
vpodzime
added
the
cherry-pick?
Contributor
Author
|
Added the label back, I think we might want to reconsider this for the next round of releases. |
Member
|
Cherry-pick: #2890 |
olehermanse
removed
the
cherry-pick?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs #2816 to be merged first. Adds one more commit that makes bigger changes in the policy, probably too disruptive for backporting.