Skip to content

Conversation

@larsewi
Copy link
Contributor

@larsewi larsewi commented Jan 24, 2024

These have not been working due to missing reports: after the @endif. @nickanderson says we might as well remove them, since they are unnecessary.

Backported from #2825

These have not been working due to missing `reports:` after the
`@endif`. @nickanderson says we might as well remove them, since they
are unnecessary.

Ticket: None
Changelog: None
Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
(cherry picked from commit f5e59f0)
@larsewi larsewi requested a review from nickanderson January 24, 2024 09:33
@larsewi
Copy link
Contributor Author

larsewi commented Jan 24, 2024

@cf-bottom Jenkins please :)

@cf-bottom
Copy link

@larsewi larsewi changed the title main.cf: Removed reports promises from mpf_augments_control bundle main.cf: Removed reports promises from mpf_augments_control bundle (3.21.x) Jan 24, 2024
@larsewi larsewi requested a review from craigcomstock January 24, 2024 09:35
@larsewi
Copy link
Contributor Author

larsewi commented Jan 31, 2024

  • FR_distributed_cleanup.test - (ENT-11215) Known failure
  • 15-upgrade-triple.01-upgrade-triple.test- (ENT-11192) Known failure

Should be safe to merge!

@nickanderson nickanderson merged commit 2469637 into cfengine:3.21.x Jan 31, 2024
@craigcomstock
Copy link
Contributor

I saw the noise from this today when I installed master hub and used 3.21.4 masterfiles module in a build project. Made a ticket: https://northerntech.atlassian.net/browse/ENT-11452

@craigcomstock craigcomstock changed the title main.cf: Removed reports promises from mpf_augments_control bundle (3.21.x) CFE-4357: main.cf: Removed reports promises from mpf_augments_control bundle (3.21.x) Mar 18, 2024
@larsewi larsewi deleted the reports-3.21.x branch July 25, 2025 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants