CFE-4335: Made AIX watchdog ignore stale pidfiles (3.21) #2842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ticket: CFE-4335 Changelog: AIX watchdog now handles stale pids Code uses /proc opportunistically only if it exists; this improves accuracy for systems with /proc and doesn't affect other systems. (Turns out this doesn't matter as the template is only for AIX which does have /proc) This leaves in place a race condition if many watchdog processes are started in very short succession, since the pidfile is not atomically checked and updated. For purposes of the watchdog this is probably good enough. (See https://stackoverflow.com/a/688365/5419599 for more on this.) (cherry picked from commit f53436b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: CFE-4335
Changelog: AIX watchdog now handles stale pids
Code uses /proc opportunistically only if it exists; this improves
accuracy for systems with /proc and doesn't affect other systems.
(Turns out this doesn't matter as the template is only for AIX which
does have /proc)
This leaves in place a race condition if many watchdog processes are
started in very short succession, since the pidfile is not atomically
checked and updated. For purposes of the watchdog this is probably good
enough. (See https://stackoverflow.com/a/688365/5419599 for more on
this.)
(cherry picked from commit f53436b)