Skip to content

Conversation

@billhimmelsbach
Copy link
Contributor

@billhimmelsbach billhimmelsbach commented Apr 17, 2025

Fixes most outstanding moderate and low severity vulnerabilities.

Changes

Package.json dev dependencies

  • vitest and @vitest/coverage-istanbul to 3.1.1 (tests run well on the new version, and I ran through the breaking changes docs to see if it affected us)
  • postcss to 8.4.31

Package.json resolutions

  • socks to >=2.8.3 (this version removes the ip package that has an outstanding vulnerability)
  • ws to >=8.18.1
  • rollup to >=2.79.2

Package.lock overrides (from dependabot)

  • postcss to 8.4.31
  • ejs to 3.1.10

How to test this PR

  • Do the tests pass?

Before (vitest: ^1.6.1)

Screenshot 2025-04-17 at 9 53 06 AM

After (vitest: ^3.1.1)

Screenshot 2025-04-17 at 9 56 39 AM

  • Do the components load normally in storybook?

Storybook

Screenshot 2025-04-17 at 9 45 30 AM

  • How does SBL look with this change?

SBL Homepage

Screenshot 2025-04-17 at 9 45 16 AM

SBL End of Filing

Screenshot 2025-04-17 at 9 45 07 AM

Closes #402

billhimmelsbach and others added 7 commits April 17, 2025 08:36
Bumps [postcss](https://github.com/postcss/postcss) from 8.4.19 to 8.4.31.
- [Release notes](https://github.com/postcss/postcss/releases)
- [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md)
- [Commits](postcss/postcss@8.4.19...8.4.31)

---
updated-dependencies:
- dependency-name: postcss
  dependency-version: 8.4.31
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [ejs](https://github.com/mde/ejs) from 3.1.9 to 3.1.10.
- [Release notes](https://github.com/mde/ejs/releases)
- [Commits](mde/ejs@v3.1.9...v3.1.10)

---
updated-dependencies:
- dependency-name: ejs
  dependency-version: 3.1.10
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
@netlify
Copy link

netlify bot commented Apr 17, 2025

Deploy Preview for cfpb-design-system-react ready!

Name Link
🔨 Latest commit 088e6b7
🔍 Latest deploy log https://app.netlify.com/sites/cfpb-design-system-react/deploys/680121bdb85dad00080a7473
😎 Deploy Preview https://deploy-preview-416--cfpb-design-system-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@billhimmelsbach billhimmelsbach marked this pull request as ready for review April 17, 2025 16:47
Copy link
Collaborator

@ojbravo ojbravo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@billhimmelsbach billhimmelsbach merged commit 8bd0bec into main Apr 17, 2025
7 checks passed
@billhimmelsbach billhimmelsbach deleted the 402-moderate-security-dep-update branch April 17, 2025 22:49
@billhimmelsbach
Copy link
Contributor Author

Just cleaning things up before my admin leave begins: merging these security vulnerability fixes in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Security] Fix low severity security vulnerabilities

3 participants