Add API and management commands for enabling/disabling flags #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willbarton
commented
Feb 23, 2021
Comment on lines
19
to
49
| def _set_flag_state( | ||
| flag_name, state, create_boolean_condition=True, request=None | ||
| ): | ||
| """ A private function to sets a boolean condition to the desired state """ | ||
| flags = get_flags(request=request) | ||
| flag = flags.get(flag_name) | ||
| if flag is None: | ||
| raise KeyError(f"No flag with name {flag_name} exists") | ||
|
|
||
| db_boolean_condition = next( | ||
| ( | ||
| c | ||
| for c in flag.conditions | ||
| if c.condition == "boolean" and getattr(c, "obj", None) is not None | ||
| ), | ||
| None, | ||
| ) | ||
|
|
||
| if db_boolean_condition is not None: | ||
| # We already have a boolean condition | ||
| boolean_condition_obj = db_boolean_condition.obj | ||
| elif db_boolean_condition is None and create_boolean_condition: | ||
| # We can create a boolean condition and we need to. | ||
| boolean_condition_obj = FlagState.objects.create( | ||
| name=flag_name, condition="boolean", value="True" | ||
| ) | ||
| else: | ||
| raise ValueError(f"Flag {flag_name} does not have a boolean condition") | ||
|
|
||
| boolean_condition_obj.value = state | ||
| boolean_condition_obj.save() |
There was a problem hiding this comment.
The body of this function is lifted from the code in Wagtail-Flags that enables/disables flags from a button in the UI. Once this is merged and released, that code should be replaced with a API calls to the enable_flag/disable_flag API introduced here.
higs4281
approved these changes
Feb 23, 2021
This change adds two flag state functions, `enable_flag` and `disable_flag`, that will either add or modify an existing boolean condition to either enable or disable a flag. It also adds an `enable_flag` and `disable_flag` management commands which call those functions. This will enable easier enabling/disabling of a flag through automations, etc. If a flag has required conditions, those will take precedence over the boolean that's added/modified. Update flags/state.py Co-authored-by: william higgins <higs4281@users.noreply.github.com>
willbarton
force-pushed
the
management-commands
branch
from
59a0949 to
821e10a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds two flag state functions,
enable_flaganddisable_flag, that will either add or modify an existing boolean condition to either enable or disable a flag.It also adds an
enable_flaganddisable_flagmanagement commands which call those functions. This will enable easier enabling/disabling of a flag through automations, etc.If a flag has required conditions, those will take precedence over the boolean that's added/modified.