Add possibility to build in nested folders #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scheibel
reviewed
Jan 24, 2018
configure
Outdated
| echo "" | ||
|
|
||
| # Create build directory | ||
| if [ ! -d "./$BUILD_DIR" ] |
Member
There was a problem hiding this comment.
Please remove the ./ so that absolute paths are handled correctly.
Jopyth
force-pushed
the
add_parent_build_directory
branch
from
5f5f1a9 to
df1cc14
Compare
Member
|
nice :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all a note: the
configurescript is awesome to use as a standalone script for other projects which are not based on cmake-init. However sometimes other projects require a setup with nested folders, e.g. expecting the build folder to be inbuild/Releaseorbuild/Debug.These changes would allow the configure script to be used in these cases.