fix: preserve externally-provided TLS certificates#232
Merged
Conversation
ensureCerts overwrites external certificates (e.g. from tailscale cert) with self-signed mkcert certs on every startup because external certs don't contain all local IPs in their SANs. Skip IP-completeness checks when the cert was not issued by mkcert. Fixes chadbyte#230 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Owner
|
@egns-ai LGTM! Clean fix, thanks. The external cert detection is clear and doesn't affect the existing mkcert flow. 👍 |
Contributor
|
This issue has been resolved in version 2.13.0-beta.3 (main). To update, run: -- Clay Deploy Bot Build anything, with anyone, in one place. |
Contributor
|
This issue has been resolved in version 2.13.0 (stable). To update, run: -- Clay Deploy Bot Build anything, with anyone, in one place. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ensureCertsoverwrites external certificates (e.g. fromtailscale cert) with self-signed mkcert certs on every daemon startupChange
Single line addition in
ensureCerts():This early-returns before the IP SAN check when the cert issuer is not mkcert, preventing regeneration of externally-provided certificates.
Test plan
tailscale cert) and verify it is preserved across daemon restarts🤖 Generated with Claude Code