Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: always honor custom message #947

Merged
merged 1 commit into from Apr 5, 2017
Merged

Conversation

@meeber
Copy link
Contributor

meeber commented Mar 26, 2017

Has #922 as a prequisite. Recommend reviewing that PR separately, and then only reviewing the diff from the final commit in this PR.

Closes #923
Closes #916

@meeber meeber force-pushed the meeber:fix-messages branch from 0f94d58 to 7f8a268 Apr 4, 2017
@meeber meeber mentioned this pull request Apr 4, 2017
4 of 10 tasks complete
@keithamus
Copy link
Member

keithamus commented Apr 4, 2017

Another great changeset @meeber! LGTM!

@meeber
Copy link
Contributor Author

meeber commented Apr 5, 2017

Thanks @keithamus!

@lucasfcosta @vieiralucas @shvaikalesh Need one more review on this one! :D

Copy link
Member

vieiralucas left a comment

LGTM

Awesome work! Especially with the tests 👍

@keithamus keithamus merged commit a515ece into chaijs:master Apr 5, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@meeber meeber deleted the meeber:fix-messages branch Aug 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.