New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: always honor custom message #947

Merged
merged 1 commit into from Apr 5, 2017

Conversation

Projects
None yet
3 participants
@meeber
Contributor

meeber commented Mar 26, 2017

Has #922 as a prequisite. Recommend reviewing that PR separately, and then only reviewing the diff from the final commit in this PR.

Closes #923
Closes #916

@meeber meeber referenced this pull request Mar 26, 2017

Merged

Overhaul bdd documentation #920

@meeber meeber referenced this pull request Apr 4, 2017

Closed

Chai Roadmap #457

4 of 10 tasks complete
@keithamus

This comment has been minimized.

Show comment
Hide comment
@keithamus

keithamus Apr 4, 2017

Member

Another great changeset @meeber! LGTM!

Member

keithamus commented Apr 4, 2017

Another great changeset @meeber! LGTM!

@meeber

This comment has been minimized.

Show comment
Hide comment
@meeber

meeber Apr 5, 2017

Contributor

Thanks @keithamus!

@lucasfcosta @vieiralucas @shvaikalesh Need one more review on this one! :D

Contributor

meeber commented Apr 5, 2017

Thanks @keithamus!

@lucasfcosta @vieiralucas @shvaikalesh Need one more review on this one! :D

@vieiralucas

LGTM

Awesome work! Especially with the tests 👍

@keithamus keithamus merged commit a515ece into chaijs:master Apr 5, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@meeber meeber deleted the meeber:fix-messages branch Aug 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment