Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: always honor custom message #947

merged 1 commit into from Apr 5, 2017


Copy link

@meeber meeber commented Mar 26, 2017

Has #922 as a prequisite. Recommend reviewing that PR separately, and then only reviewing the diff from the final commit in this PR.

Closes #923
Closes #916

@meeber meeber mentioned this pull request Apr 4, 2017
10 tasks
Copy link

Another great changeset @meeber! LGTM!

Copy link
Contributor Author

meeber commented Apr 5, 2017

Thanks @keithamus!

@lucasfcosta @vieiralucas @shvaikalesh Need one more review on this one! :D

Copy link

@vieiralucas vieiralucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Awesome work! Especially with the tests 👍

@keithamus keithamus merged commit a515ece into chaijs:master Apr 5, 2017
@meeber meeber deleted the fix-messages branch August 6, 2017 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants