Skip to content

fix(cli): attached add fix #1661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 15, 2024
Merged

fix(cli): attached add fix #1661

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac68d9b
fix(cli): attached add fix
migmartri Dec 15, 2024
90bd3c7
fix linter
migmartri Dec 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions app/cli/cmd/attached_integration_add.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ func newAttachedIntegrationAttachCmd() *cobra.Command {
Use: "add",
Aliases: []string{"attach"},
Short: "Attach an existing registered integration to a workflow",
Example: ` chainloop integration attached add --workflow deadbeef --integration beefdoingwell --opt projectName=MyProject --opt projectVersion=1.0.0`,
RunE: func(cmd *cobra.Command, args []string) error {
Example: ` chainloop integration attached add --workflow deadbeef --project my-project --integration beefdoingwell --opt projectName=MyProject --opt projectVersion=1.0.0`,
RunE: func(_ *cobra.Command, _ []string) error {
// Find the integration to extract the kind of integration we care about
integration, err := action.NewRegisteredIntegrationDescribe(actionOpts).Run(integrationName)
if err != nil {
Expand Down Expand Up @@ -67,7 +67,7 @@ func newAttachedIntegrationAttachCmd() *cobra.Command {
cmd.Flags().StringVar(&workflowName, "workflow", "", "name of the workflow to attach this integration")
cobra.CheckErr(cmd.MarkFlagRequired("workflow"))

cmd.Flags().StringVar(&workflowName, "project", "", "name of the project the workflow belongs to")
cmd.Flags().StringVar(&projectName, "project", "", "name of the project the workflow belongs to")
cobra.CheckErr(cmd.MarkFlagRequired("project"))

// StringSlice seems to struggle with comma-separated values such as p12 jsonKeys provided as passwords
Expand Down
Loading