feat(events): Send events for workflow contract changes #1663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
migmartri
reviewed
Dec 16, 2024
| ) | ||
|
|
||
| // WorkflowContractBase is the base struct for workflow contract events | ||
| type WorkflowContractBase struct { |
There was a problem hiding this comment.
Thanks @javirln!
BTW, I am curious to see what's your take on the testing framework I put here for the generation of events, let me know what you think.
Signed-off-by: Javier Rodriguez <javier@chainloop.dev>
javirln
force-pushed
the
feat/1628-contracts
branch
from
23f8f64 to
3e4f441
Compare
migmartri
approved these changes
Dec 16, 2024
| { | ||
| "ActionType": "WorkflowContractContractAttached", | ||
| "TargetType": "WorkflowContract", | ||
| "TargetID": "1089bb36-e27b-428b-8009-d015c8737c54", |
| // or if it has been attached or detached | ||
| if opts.ContractID != nil { | ||
| if preUpdateWorkflow.ContractID != uuid.Nil { | ||
| uc.dispatchContractEvent(ctx, orgID, preUpdateWorkflow.ContractID, preUpdateWorkflow.ContractName, wf.ID, wf.Name, false) |
There was a problem hiding this comment.
ok, so this is detaching the previous contract and attaching it to a new one?
There was a problem hiding this comment.
yes, in case of a change of contract it sends the detach and attach. See for example when we create a new workflow, we send the event of a new contract attached
Signed-off-by: Javier Rodriguez <javier@chainloop.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch creates a new event type
WorkflowContractand a few types associated with it. Instruments the code base to be able to send events related to that resource.Ref #1628