Skip to content

feat(cli): improve policy output on describe #1681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 19, 2024
Merged

feat(cli): improve policy output on describe #1681

merged 3 commits into from
Dec 19, 2024

Conversation

@migmartri
Copy link
Member

@migmartri migmartri commented Dec 18, 2024 •
edited
Loading

Adds policy output in att status and improves the output in wf run describe

  • Clearly showing material policies in the context of the wrapping materials
  • Attestation policies were moved to the attestation section on the top
  • Violations output has been improved with list-type output and coloring
  • More condensed view overall

before

image

after

image

refs #1616

@migmartri
feat(cli): improve policy output on describe
03229f7 
Signed-off-by: Miguel Martinez <miguel@chainloop.dev>
@migmartri migmartri requested review from javirln and jiparis December 18, 2024 23:52
@migmartri
fix coloring
780e0a2 
Signed-off-by: Miguel Martinez <miguel@chainloop.dev>
@migmartri
show policies in status
e692dec 
Signed-off-by: Miguel Martinez <miguel@chainloop.dev>
jiparis
jiparis approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@jiparis jiparis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@migmartri migmartri merged commit ba7ce12 into chainloop-dev:main Dec 19, 2024
13 checks passed
@migmartri migmartri deleted the 1616-improve branch December 19, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jiparis jiparis jiparis approved these changes

@javirln javirln javirln approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@migmartri @jiparis @javirln