refactor: run attestation-level policy evaluations in crafting layer #1689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miguel Martinez <miguel@chainloop.dev>
Signed-off-by: Miguel Martinez <miguel@chainloop.dev>
migmartri
commented
Jan 2, 2025
|
|
||
| // execute policy evaluations | ||
| // We do not want to evaluate policies here during render since we want to do it in a separate step | ||
| statement, err := renderer.RenderStatement(ctx) |
There was a problem hiding this comment.
I thought about also running it on att.add but I am not sure it's needed yet.
There was a problem hiding this comment.
Probably not, since we want to block only on "push"
| } | ||
|
|
||
| // We do not want to evaluate policies here during render since we want to do it in a separate step | ||
| statement, err := renderer.RenderStatement(ctx, chainloop.WithSkipPolicyEvaluation(true)) |
There was a problem hiding this comment.
renderer never evaluates policies anymore
jiparis
reviewed
Jan 2, 2025
| // addPolicyResults adds policy evaluation results to the statement. It does it by deserializing the predicate from a structpb.Struct, | ||
| // filling PolicyEvaluations, and serializing it again to a structpb.Struct object, using JSON as an intermediate representation. | ||
| // Note that this is needed because intoto predicates are generic structpb.Struct | ||
| func addPolicyResults(statement *intoto.Statement, policyResults []*v1.PolicyEvaluation) error { |
aarlint
pushed a commit
to aarlint/chainloop
that referenced
this pull request
Jan 3, 2025
…hainloop-dev#1689) Signed-off-by: Miguel Martinez <miguel@chainloop.dev> Signed-off-by: Austin Arlint <aarlint@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runs the attestation-related policy evaluations in the crafting layer storing it in the state.
This is a pre-requisite for #1685.
In practice nothing changes except that policy-level evaluations happen in
statusandpushand then the renderer layer just takes the info in the state.