Skip to content

Conversation

jiparis
Copy link
Member

@jiparis jiparis commented Feb 13, 2025

This PR introduces a new parameter (Verify: true) in the request to perform bundle verification on WorkfloRun/View endpoint.
Note this is just a convenience and doesn't replace client side validation.
Refs #914

> buf curl --http2-prior-knowledge --protocol grpc  -H "Authorization: Bearer $CHAINLOOP_TOKEN" -d '{"id":"844be0a2-f6cd-4c4b-9187-b8496b11a86c", "verify":true}' http://localhost:9000/controlplane.v1.WorkflowRunService/View
...    },
    "verification": {
      "verified": true
    }
  }
}

Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
@jiparis jiparis requested review from javirln and migmartri February 13, 2025 17:18
Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
Copy link
Member

@migmartri migmartri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jiparis

I put inline one question about knowing how this code behaves with old attestations that don't have bundle

Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
@jiparis jiparis merged commit 84a10ab into chainloop-dev:main Feb 17, 2025
13 checks passed
@jiparis jiparis deleted the PFM-450-server branch February 17, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants