Skip to content

Conversation

jiparis
Copy link
Member

@jiparis jiparis commented Feb 19, 2025

This PR ensures Signatures are not base64 encoded twice. It's backwards compatible with current attestations.

Fixes #1832

Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
@jiparis jiparis requested review from javirln and migmartri February 19, 2025 09:11
Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
@jiparis jiparis merged commit bfa42fe into chainloop-dev:main Feb 19, 2025
13 checks passed
@jiparis jiparis deleted the pfm-2470-1832 branch February 19, 2025 09:53
jiparis added a commit to jiparis/chainloop that referenced this pull request Feb 19, 2025
…dev#1833)"

This reverts commit bfa42fe.

Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
migmartri pushed a commit that referenced this pull request Feb 19, 2025
…1836)

Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: signatures in DSSE envelopes are base64 encoded twice

2 participants