feat(signing): support SignServer authentication with client certificate #1858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
migmartri
approved these changes
Feb 26, 2025
Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to configure SignServer for client certificate authentication, as described at https://docs.keyfactor.com/signserver/latest/client-certificate-authorizer
It also removes unused flags in the SignServer integration logic.
Given that End Entities have been created in EJBCA, and SignServer Sign Worker has been configured properly to accept payloads from those users, attestation can be signed and pushed this way:
> chainloop att push --key signserver://localhost:8443/PlainSigner --signserver-ca-path ../keyfactor/localhost-chain.pem --signserver-client-cert ../keyfactor/clientcert/Chainloop.pem INF push completed ┌───────────────────────────┬─────────────────────────────────────────────────────────────────────────┐ │ Initialized At │ 26 Feb 25 18:09 UTC │ ├───────────────────────────┼─────────────────────────────────────────────────────────────────────────┤ │ Attestation ID │ f30b177d-3759-4f00-810f-73315900a45b │ │ Digest │ sha256:cf02fa769799df468400af74cd167a3e86b5363f700477b049cc7c8ab923da71 │ │ Organization │ my-org │ │ Name │ mywf │ │ Project │ myproject │ │ Version │ v0.174.0 (prerelease) │ │ Contract │ myproject-mywf (revision 95) │ │ Policy violation strategy │ ADVISORY │ │ Policies │ ------ │ │ │ source-commit: Ok │ │ │ sbom-present: missing SBOM material │ └───────────────────────────┴────────────────────────────────────────────────────────Fixes #1245