feat: create crafting schema v2 #2461
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sylwester Piskozub <sylwesterpiskozub@gmail.com>
Signed-off-by: Sylwester Piskozub <sylwesterpiskozub@gmail.com>
Signed-off-by: Sylwester Piskozub <sylwesterpiskozub@gmail.com>
migmartri
approved these changes
Oct 13, 2025
Member
migmartri
left a comment
migmartri
left a comment
There was a problem hiding this comment.
LGTM!
Is there any way to mark the other message as deprecated?
| // that defines the schema of the workflowRun | ||
| message CraftingSchemaV2 { | ||
| string api_version = 1 [(buf.validate.field).string.const = "chainloop.dev/v1"]; | ||
| string kind = 2 [(buf.validate.field).string.const = "Contract"]; |
Collaborator
Author
I'll do that in another PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds crafting schema v2 that follows structure established by other existing compliance resources.
chainloop.dev/v1is used as the only viable api version