feat: add summary table in plugins SDK #250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
migmartri
commented
Jul 19, 2023
| return fmt.Errorf("workflowRun not found") | ||
| } | ||
|
|
||
| workflowMetadata := &sdk.ChainloopMetadata{ |
There was a problem hiding this comment.
I needed to increase the amount of metadata that we injected in the plugin. Including now information about the workflow run
| }, nil | ||
| } | ||
|
|
||
| func MetadataSDKToProto(in *sdk.ChainloopMetadata) *ExecuteRequest_Metadata { |
There was a problem hiding this comment.
the new plugin system needed to be extended to know how to translate the new metadata payload
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
danlishka
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
SummaryTable(req)helper method to the plugins SDK that returns an workflow + attestation summary in text/markdown or html format (configurable)This patch also updates the three integrations that use these kind of metadata
Discord
Slack
Email
Closes #249