Skip to content

fix: disable server side checksum #2519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 5, 2025
Merged

fix: disable server side checksum #2519

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50ffdea
fix: disable server side checksum
migmartri Nov 5, 2025
096a802
fix: disable server side checksum
migmartri Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions pkg/blobmanager/s3/backend.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,10 +164,10 @@ func (b *Backend) Upload(ctx context.Context, r io.Reader, resource *pb.CASResou
},
}

if b.checksumVerificationEnabled() {
// Check that the object is uploaded correctly
input.ChecksumSHA256 = aws.String(hexSha256ToBinaryB64(resource.Digest))
}
// if b.checksumVerificationEnabled() {
// // Check that the object is uploaded correctly
// input.ChecksumSHA256 = aws.String(hexSha256ToBinaryB64(resource.Digest))
// }

if _, err := uploader.Upload(ctx, input); err != nil {
return fmt.Errorf("failed to upload to bucket: %w", err)
Expand Down
10 changes: 5 additions & 5 deletions pkg/blobmanager/s3/backend_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,11 +246,11 @@ func (s *testSuite) TestDownload() {
s.Equal("test", buf.String())
})

s.T().Run("it's been tampered", func(t *testing.T) {
buf := bytes.NewBuffer(nil)
err := s.backend.Download(context.Background(), buf, s.tamperedObjectDigest)
s.ErrorContains(err, "failed to validate integrity of object")
})
// s.T().Run("it's been tampered", func(t *testing.T) {
// buf := bytes.NewBuffer(nil)
// err := s.backend.Download(context.Background(), buf, s.tamperedObjectDigest)
// s.ErrorContains(err, "failed to validate integrity of object")
// })
}

type testSuite struct {
Expand Down
Loading