feat(keyless): signing use case #859
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
migmartri
approved these changes
May 31, 2024
| csr []byte | ||
| } | ||
|
|
||
| func (s *signingUseCaseTestSuite) TestSigningUseCase_CreateSigningCert() { |
Member
There was a problem hiding this comment.
nitpick: I think this is smth I asked @javirln once, but is using _ i.e TestSigningUseCase_CreateSigningCert go idiomatic?
Member
Author
There was a problem hiding this comment.
It's the suggestion from the IDE, I believe it's some "idiomatic", but I don't think there is a written rule.
Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first of a set of PRs to implement keyless signing in chainloop vault and CLI.
This PR focuses on the implementation of the signing use case. The use case receives a certificate request and signs it with a configured certificate authority. It uses some of the Sigstore logic for this purpose.
Refs #865