Wasm: deferred parsing #1243
Merged
Wasm: deferred parsing #1243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This change is mostly related to WebAssembly/design#719 |
Contributor
Author
|
@MikeHolman @commonlisp Can you review this please? |
Contributor
Author
|
ping |
| mov eax, ecx | ||
| #endif | ||
| pop ebp | ||
| // Although we don't restore ESP here on WinCE, this is fine because script profiler is not shipped for WinCE. |
Contributor
There was a problem hiding this comment.
what does this comment mean?
Contributor
Author
There was a problem hiding this comment.
I got this from another thunk in this file, I don't really know what it means exactly either
Contributor
|
right now this will have memory cost, so a bit hesitant about merging unless it will be used |
Made some Wasm tracing available in test build Update basic.wast to latest syntax (haven't update the baseline, because I am unsure what it is supposed to do)
Added new class WasmModuleGenerator which reads only what is necessary to create the wasm module. Then WasmBytecodeGenerator only generates the bytecode for the function bodies. Added thunks for x64/x86 for deferred parsing entry points. Simplified logic for LazyTraps
Create a new ArenaAllocator on the WasmBinaryReader that has the same lifetime as the reader
| m_scriptContext(scriptContext), | ||
| m_recycler(scriptContext->GetRecycler()) | ||
| { | ||
| m_reader = RecyclerNew(m_recycler, Binary::WasmBinaryReader, scriptContext, binaryBuffer, binaryBufferLength); |
Contributor
There was a problem hiding this comment.
I think this can be leaf.
Contributor
|
|
| body->GetAsmJsFunctionInfo()->SetIsHeapBufferConst(true); | ||
|
|
||
| WasmReaderInfo* readerInfo = RecyclerNew(m_recycler, WasmReaderInfo); | ||
| WasmReaderInfo* readerInfo = RecyclerNewLeaf(m_recycler, WasmReaderInfo); |
Contributor
There was a problem hiding this comment.
i think this can't be leaf
This reverts commit 1692559.
Cellule
added a commit
to Cellule/ChakraCore
that referenced
this pull request
Jul 20, 2016
Merge pull request chakra-core#1243 from Cellule:wasm/deferred Implement deferred parsing for Wasm functions under a flag `-on:wasmdeferred` Added new class WasmModuleGenerator which reads only what is necessary to create the wasm module. Then WasmBytecodeGenerator only generates the bytecode for the function bodies. Simplified logic for LazyTraps Added instrumentation for `-profile` with Wasm Took the opportunity to do some cleanup in the Wasm classes notably some unused methods and some rearrangement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement deferred parsing for Wasm functions under a flag
-on:wasmdeferredAdded new class WasmModuleGenerator which reads only what is necessary to create the wasm module.
Then WasmBytecodeGenerator only generates the bytecode for the function bodies.
Simplified logic for LazyTraps
Added instrumentation for
-profilewith WasmTook the opportunity to do some cleanup in the Wasm classes notably some unused methods and some rearrangement.
This change is