Skip to content

Conversation

@Cellule
Copy link
Contributor

@Cellule Cellule commented Jul 20, 2016

Simple node program to convert the wasm testsuite to binary C
an also create/update the baseline files Remove failing tests between interpreter and jit for the time being


This change is Reviewable

@Cellule
Copy link
Contributor Author

Cellule commented Jul 20, 2016

@MikeHolman can you review this please ?

@Cellule
Copy link
Contributor Author

Cellule commented Jul 20, 2016

You can ignore files that are located in WasmSpec/baselines WasmSpec/testsuite-bin
The files in WasmSpec/testsuite comes from https://github.com/WebAssembly/testsuite (mirror source: https://github.com/WebAssembly/spec/tree/master/ml-proto/test)
I have commented out some of those tests because they produce different result between our interpreter and jit which makes creating a baseline difficult.
I have also excluded

      [
        "f32",
        "f32_cmp",
        "f64",
        "f64_cmp",
        "float_exprs",
        "float_misc",
        "i32",
        "memory_redundancy",
        "nan-propagation",
        "resizing",
      ]

For the same reason. Most of the issue are because of NaN as we discussed offline.

This should give us some kind of coverage and way to verify that our implementations are correct.

@Cellule
Copy link
Contributor Author

Cellule commented Jul 20, 2016

For the time being, the dev needs to have sexpr-wasm locally to regenerate those binaries.
I will investigate if/how we can include sexpr-wasm's third-party code directly into our source base.

https://github.com/WebAssembly/spec


The files in test/WasmSpec/testsuite are licensed as follows unless otherwise stated in the file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as follows [](start = 50, length = 10)

as follows? nothing follows

@MikeHolman
Copy link
Contributor

:shipit:

Can also create/update the baseline files
Remove failing tests between interpreter and jit for the time being
@Cellule Cellule merged commit 25deb22 into chakra-core:WebAssembly Jul 21, 2016
Cellule added a commit that referenced this pull request Jul 21, 2016
Merge pull request #1305 from Cellule:wasm/testsuite

Simple node program to convert the wasm testsuite to binary C
an also create/update the baseline files Remove failing tests between interpreter and jit for the time being
@Cellule Cellule deleted the wasm/testsuite branch July 25, 2016 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants