Skip to content
This repository was archived by the owner on Sep 20, 2024. It is now read-only.

Conversation

@MWFIAE
Copy link
Contributor

@MWFIAE MWFIAE commented Apr 26, 2021

Fixes #422

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@changeset-bot
Copy link

changeset-bot bot commented Apr 26, 2021

⚠️ No Changeset found

Latest commit: 1eddbe1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Apr 26, 2021

@MWFIAE is attempting to deploy a commit to the Chakra UI Team on Vercel.

A member of the Team first needs to authorize it.

@MWFIAE MWFIAE changed the title Add srcset support to CImage feat(image): Add srcset support to CImage Apr 29, 2021
Copy link
Collaborator

@codebender828 codebender828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. thanks @MWFIAE Looks good to me! Gonna run tests and merge.

@vercel
Copy link

vercel bot commented May 4, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

chakra-ui-vue – ./

🔍 Inspect: https://vercel.com/chakra-ui/chakra-ui-vue/3F4hQ34Qgr7BvrZDpqkhahRx51DE
✅ Preview: https://chakra-ui-vue-git-fork-mwfiae-patch-1-chakra-ui.vercel.app

Copy link
Collaborator

@codebender828 codebender828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good here @MWFIAE

Would you like to include a test to make sure that the srcset attribute is covered as well?
Something along these lines?

it('fallback src works', async () => {
  renderComponent({ template: '<CImage alt="My Image Description" src="IMAGE_SRC" srcset="IMAGE_SRCSET" />' })
  await wait(() => {
    expect(screen.getByAltText(/My Image Description/i)).toHaveAttribute('srcset', 'IMAGE_SRCSET')
  })
})

@MWFIAE
Copy link
Contributor Author

MWFIAE commented May 12, 2021

@codebender828 Can you please take another look? :)

Copy link
Collaborator

@codebender828 codebender828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @MWFIAE

@MWFIAE
Copy link
Contributor Author

MWFIAE commented Jun 3, 2021

Hi any news? @codebender828

@codebender828 codebender828 merged commit ace19f2 into chakra-ui:develop Jun 8, 2021
@MWFIAE MWFIAE deleted the patch-1 branch June 8, 2021 14:28
@codebender828
Copy link
Collaborator

@all-contributors please add @MWFIAE for code, tests

@allcontributors
Copy link
Contributor

@codebender828

I've put up a pull request to add @MWFIAE! 🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Properly support srcSet in the c-image component

2 participants