-
Notifications
You must be signed in to change notification settings - Fork 137
feat(image): Add srcset support to CImage #423
Conversation
|
|
@MWFIAE is attempting to deploy a commit to the Chakra UI Team on Vercel. A member of the Team first needs to authorize it. |
codebender828
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great. thanks @MWFIAE Looks good to me! Gonna run tests and merge.
|
This pull request is being automatically deployed with Vercel (learn more). chakra-ui-vue – ./🔍 Inspect: https://vercel.com/chakra-ui/chakra-ui-vue/3F4hQ34Qgr7BvrZDpqkhahRx51DE |
codebender828
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good here @MWFIAE
Would you like to include a test to make sure that the srcset attribute is covered as well?
Something along these lines?
it('fallback src works', async () => {
renderComponent({ template: '<CImage alt="My Image Description" src="IMAGE_SRC" srcset="IMAGE_SRCSET" />' })
await wait(() => {
expect(screen.getByAltText(/My Image Description/i)).toHaveAttribute('srcset', 'IMAGE_SRCSET')
})
})|
@codebender828 Can you please take another look? :) |
codebender828
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @MWFIAE
|
Hi any news? @codebender828 |
|
@all-contributors please add @MWFIAE for code, tests |
|
I've put up a pull request to add @MWFIAE! 🎉 |
Fixes #422
Types of changes