Skip to content
This repository was archived by the owner on Sep 20, 2024. It is now read-only.

Conversation

@abelnnieva
Copy link
Contributor

Description

Fixed a bug in the defaultValue prop of the MenuOption.

Motivation and Context

The MenuOption is not using the value of the defaultValue prop. Also, for the checkbox type, the defaultValue prop must include the Array type.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@changeset-bot
Copy link

changeset-bot bot commented Jul 20, 2021

🦋 Changeset detected

Latest commit: 496e9df

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@chakra-ui/vue Patch
@chakra-ui/nuxt Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jul 20, 2021

@abelnnieva is attempting to deploy a commit to the Chakra UI Team on Vercel.

A member of the Team first needs to authorize it.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 20, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 496e9df:

Sandbox Source
Chakra UI Vue (0.X) Starter Template Configuration
chakra-ui-nuxt-demo Configuration

@peoray
Copy link
Contributor

peoray commented Jul 20, 2021

@abelnnieva Thank you for spotting the issue and offering a PR.
Quick question, what do you mean by the checkbox type?

@vercel
Copy link

vercel bot commented Jul 20, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

chakra-ui-vue – ./

🔍 Inspect: https://vercel.com/chakra-ui/chakra-ui-vue/4vUSWEvJ3TDtowcMLru7ru8dxD41
✅ Preview: https://chakra-ui-vue-git-fork-abelnnieva-fix-menu-def-1f15a5-chakra-ui.vercel.app

@codebender828
Copy link
Collaborator

@abelnnieva Thank you for spotting the issue and offering a PR.
Quick question, what do you mean by the checkbox type?

I think he refers to this ⬇️

image

https://vue.chakra-ui.com/menu#menu-option-groups

@codebender828 codebender828 self-requested a review July 20, 2021 05:18
Copy link
Collaborator

@codebender828 codebender828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @abelnnieva

@abelnnieva
Copy link
Contributor Author

@abelnnieva Thank you for spotting the issue and offering a PR.
Quick question, what do you mean by the checkbox type?

@peoray It is the type property of the CMenuOptionGroup which can be radio or checkbox.

@codebender828
Copy link
Collaborator

@all-contributors please add @abelnnieva for bugs, code

@allcontributors
Copy link
Contributor

@codebender828

This project's configuration file has malformed JSON: .all-contributorsrc. Error:: Unexpected token } in JSON at position 7542

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants