fix(vue): handle vmodel directive #110
Conversation
Codecov Report
@@ Coverage Diff @@
## main #110 +/- ##
===========================================
- Coverage 100.00% 99.65% -0.35%
===========================================
Files 3 11 +8
Lines 145 587 +442
Branches 10 58 +48
===========================================
+ Hits 145 585 +440
- Misses 0 2 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Thank you for working on this @Shyrro ✨ |
Shyrro
force-pushed
the
fix/vmodel
branch
2 times, most recently
from
e54ba8a to
295b330
Compare
There was a problem hiding this comment.
Awesome work @Shyrro Thanks for working on that!
To merge and release this we need a changeset file in the PR branch.
Kindly run 'pnpm changeset' in the repo root, choose vue with a minor bump and describe the changes as you would expect them in a changelog.
You can read more about the process here: https://github.com/changesets/changesets/blob/main/docs/adding-a-changeset.md
Or reach out to me, and we can do it together.
packages/vue/package.json
Outdated
| "@testing-library/vue": "6.6.1", | ||
| "@types/jsdom": "20.0.1", | ||
| "@types/testing-library__jest-dom": "5.14.5", | ||
| "@vitejs/plugin-vue": "^4.0.0", |
There was a problem hiding this comment.
suggestion: Let's pin the devDeps to ensure reproducible builds. We use renovate to schedule those updated automatically.
Kindly update the lock file too.
| "@vitejs/plugin-vue": "^4.0.0", | |
| "@vitejs/plugin-vue": "4.0.0", |
| import { screen, render, fireEvent } from '@testing-library/vue' | ||
| import PolyTest from './poly-test.vue' | ||
|
|
||
| describe('SFC related features', () => { |
There was a problem hiding this comment.
praise (non-blocking): love the test suite!
Thanks for your review @TimKolberger ! Will try to update to changelog today ! |
Signed-off-by: Shyrro <zsahmane@gmail.com>
Signed-off-by: Shyrro <zsahmane@gmail.com>
Signed-off-by: Shyrro <zakaria.sahmane@decathlon.com>
|
Hi @TimKolberger ! I just updated the changelog + updated the lock file, can you please check if everything is okay ? Thanks ! |
2 participants
Signed-off-by: Shyrro zsahmane@gmail.com
Add support for
v-modeldirective