Support of git submodules ?

[bertho-zero]

Discussed in #817

^{Originally posted by bertho-zero May 30, 2022}
I have a monorepo organized with a git submodule and would like to know how this is handled for the git part if I start using changesets.

The monorepo is private and part of it is public, it looks like this:

/monorepo
  /packages
    /package-a
    /package-b
  /public # git submodule
    /package-c
    /package-d

So packages in public don't have the same git history as packages in packages, how do you think that will react?

For example, the cwd in the method applyReleasePlan is always the same:

changesets/packages/apply-release-plan/src/index.ts

Line 65 in 34933f0

let cwd = packages.root.dir;

But the method getCommitsThatAddFiles does not work without additional -C option to git:

changesets/packages/git/src/index.ts

Lines 91 to 101 in 34933f0

	await spawn(
	"git",
	[
	"log",
	"--diff-filter=A",
	"--max-count=1",
	"--pretty=format:%h:%p",
	gitPath
	],
	{ cwd }
	)

If I do the equivalent manually:

git log --diff-filter=A --max-count=1 --pretty=format:%h:%p -- public/package-c/package.json
# nothing

but the following works:

 git -C public log --diff-filter=A --max-count=1 --pretty=format:%h:%p -- package-c/package.json
# return 588fc62:b5271a4

[Andarist]

So packages in public don't have the same git history as packages in packages, how do you think that will react?

Honestly - I don't know. This would have to be tested out. I'm afraid that I don't have enough time to investigate this on my own. I would accept PRs improving such setups - but if it turns out to be more involved I would recommend discussing possible approaches first and only getting to coding after we settle on the solution.

But the method getCommitsThatAddFiles does not work without additional -C option to git:

I don't think this is true - { cwd } already "invokes" this git command in the target directory. -C changes how git behaves but you invoke it from a different directory than we do. The end result should be the same here - it's just matter of how it's achieved.

[emgk]

+1, did you find any workaround for this, @bertho-zero? :)

[bertho-zero]

@emgk I replaced the submodule with a subtree 😅

[bertho-zero]

The problem I'm currently seeing with the subtree is that git subtree push doesn't push GitHub tags and releases.

In my case, the monorepo is private and part of it is public. Public packages are published to NPM, but Git tags and releases remain only in the private repo.