-
Notifications
You must be signed in to change notification settings - Fork 714
Add --enable-pnpm-catalog flag to opt into pnpm workspace catalog detection #1714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 3f7aac5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1714 +/- ##
=======================================
Coverage ? 80.87%
=======================================
Files ? 54
Lines ? 2311
Branches ? 703
=======================================
Hits ? 1869
Misses ? 437
Partials ? 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
60c1607
to
17358fd
Compare
Found out about pnpm catalogs yesterday (awesome feature!) and this is the only blocker stopping us from adopting them. Anything we can do to help with merging this PR? |
I'm happy to work on any change that would be necessary to get this through the finish line. |
Is |
Thanks for the reply!
This doesn't seem right. If my package depends on React 17 and I bump it to 18, it requires a version bump of my package. But happy to have a flag if that's what it takes. I can try to take a stab at it next week. |
Changesets will generate a change for any files in a normal (flat) repository right? In the monorepo catalog case, there could be no file changes under each of the packages, but the workspace file (and associated catalog entries) IS modified, which would mean a change, which is what @cyril-sf has implemented I think? |
@chriswiggins correct! |
23858af
to
7edcd69
Compare
…ection When using pnpm workspaces with the catalog feature, updating a dependency version in the catalog section of pnpm-workspace.yaml is detected as a change by changesets - Allow changeset add and changeset status to include updates from pnpm workspace catalogs when requested via the new flag. - Keep catalog-only edits ignored by default, while documenting and surfacing the opt-in behaviour.
7edcd69
to
3f7aac5
Compare
When using pnpm workspaces with the catalog feature, updating a dependency version in the catalog section of pnpm-workspace.yaml is detected as a change by changesets.
Allow
changeset add
andchangeset status
to include updates from pnpm workspace catalogs when requested via the new flag.Fixes #1707