Skip to content

Fix for issue number #57 #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 29, 2019
Merged

Fix for issue number #57 #58

merged 3 commits into from
Mar 29, 2019

Conversation

@Polaris000
Copy link
Contributor

@Polaris000 Polaris000 commented Jan 11, 2019 •
edited
Loading

Steps:

@Polaris000
Copy link
Contributor Author

Polaris000 commented Jan 11, 2019

I thought of this because the grimoirelab.github.io site redirected to the grimoirelab homepage where I realized that a favicon appeared.

@Polaris000 Polaris000 closed this Jan 11, 2019
@Polaris000 Polaris000 deleted the favicon_add_branch branch January 11, 2019 16:09
@Polaris000 Polaris000 restored the favicon_add_branch branch January 13, 2019 16:42
@Polaris000 Polaris000 reopened this Jan 13, 2019
@Polaris000 Polaris000 mentioned this pull request Jan 24, 2019
Open
@Polaris000
Copy link
Contributor Author

Polaris000 commented Feb 13, 2019

@jgbarah please have a look.

@jgbarah
Copy link
Contributor

jgbarah commented Feb 15, 2019

Sorry for being late with this.

Did you check that this enough for the favicon to be served?

@Polaris000
Copy link
Contributor Author

Polaris000 commented Feb 15, 2019

screenshot from 2019-02-15 22-06-40

@Polaris000
Copy link
Contributor Author

Polaris000 commented Feb 15, 2019 •
edited
Loading

The above screenshot shows the now-present favicon. Please have a look @jgbarah .

jgbarah
jgbarah approved these changes Mar 29, 2019
View reviewed changes
Copy link
Contributor

@jgbarah jgbarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@jgbarah jgbarah merged commit 74384c1 into chaoss:master Mar 29, 2019
@Polaris000 Polaris000 deleted the favicon_add_branch branch May 21, 2019 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jgbarah jgbarah jgbarah approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Polaris000 @jgbarah