fix: split codecov yaml and upload in release flow

Author: Spelkington

.github/workflows/release.yml

@@ -70,6 +70,9 @@ jobs:
             --output-style=stream \
             --logger "console;verbosity=minimal"
 
+      - name: Sync Codecov flags
+        run: pnpm nx run tests:coverage:sync
+
       - name: Configure Git
         run: |
           git config user.name "github-actions[bot]"
@@ -191,27 +194,6 @@ jobs:
       #       gh release edit "${VERSION}" --notes-file /tmp/combined-notes.md
       #     fi
 
-      - name: Install Codecov CLI
-        if: always()
-        run: |
-          curl https://keybase.io/codecovsecurity/pgp_keys.asc \
-            | gpg --no-default-keyring --keyring trustedkeys.gpg --import
-          curl -Os https://cli.codecov.io/latest/linux/codecov
-          curl -Os https://cli.codecov.io/latest/linux/codecov.SHA256SUM
-          curl -Os https://cli.codecov.io/latest/linux/codecov.SHA256SUM.sig
-          gpg --no-default-keyring --keyring trustedkeys.gpg \
-            --verify codecov.SHA256SUM.sig codecov.SHA256SUM
-          shasum -a 256 -c codecov.SHA256SUM
-          sudo chmod +x codecov
-          sudo mv codecov /usr/local/bin/codecov
-
-      - name: Upload coverage to Codecov
-        if: always()
-        continue-on-error: true
-        env:
-          CODECOV_TOKEN: ${{ secrets.FLOWTHRU_CODECOV_TOKEN }}
-        run: pnpm nx run tests:coverage:upload
-
       - name: Publish preview to NuGet
         if: steps.release.outputs.changed == 'true'
         env:
@@ -233,3 +215,24 @@ jobs:
             --api-key "${FLOWTHRU_NUGET_API_KEY}" \
             --source https://api.nuget.org/v3/index.json \
             --skip-duplicate
+
+      - name: Install Codecov CLI
+        if: always()
+        run: |
+          curl https://keybase.io/codecovsecurity/pgp_keys.asc \
+            | gpg --no-default-keyring --keyring trustedkeys.gpg --import
+          curl -Os https://cli.codecov.io/latest/linux/codecov
+          curl -Os https://cli.codecov.io/latest/linux/codecov.SHA256SUM
+          curl -Os https://cli.codecov.io/latest/linux/codecov.SHA256SUM.sig
+          gpg --no-default-keyring --keyring trustedkeys.gpg \
+            --verify codecov.SHA256SUM.sig codecov.SHA256SUM
+          shasum -a 256 -c codecov.SHA256SUM
+          sudo chmod +x codecov
+          sudo mv codecov /usr/local/bin/codecov
+
+      - name: Upload coverage to Codecov
+        if: always()
+        continue-on-error: true
+        env:
+          CODECOV_TOKEN: ${{ secrets.FLOWTHRU_CODECOV_TOKEN }}
+        run: pnpm nx run tests:coverage:upload

tests/project.json

@@ -40,12 +40,22 @@
         "parallel": false
       }
     },
+    "coverage:sync": {
+      "//": "Sync codecov.yml flags and components from the current project graph and stage the file for commit. Must run before the release commit so the updated codecov.yml is included.",
+      "executor": "nx:run-commands",
+      "options": {
+        "commands": [
+          "node scripts/sync-codecov-flags.mjs"
+        ],
+        "cwd": "{workspaceRoot}",
+        "parallel": false
+      }
+    },
     "coverage:upload": {
-      "//": "Sync Codecov flags from the current project graph, then upload all coverage.cobertura.xml files found under tests/. Assumes tests have already been run. Requires CODECOV_TOKEN env var and the codecov CLI on PATH.",
+      "//": "Upload all coverage.cobertura.xml files found under tests/ to Codecov. Assumes tests have already been run and coverage:sync has been called. Requires CODECOV_TOKEN env var and the codecov CLI on PATH.",
       "executor": "nx:run-commands",
       "options": {
         "commands": [
-          "node scripts/sync-codecov-flags.mjs",
           "bash scripts/upload-coverage.sh"
         ],
         "cwd": "{workspaceRoot}",