-
Notifications
You must be signed in to change notification settings - Fork 12k
Fix tooltip error and add fixed steps to linear scale #1978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ines as stated in docs.
…ines as stated in docs.
# Conflicts: # src/core/core.helpers.js
|
And sorry for the merge conflict, tried to amend after pushing. |
Added ticks.fixedStepSize configuration parameter to force linear scale steps.
|
I have updated the pull request which now also sports a ticks.fixedStepSize option to force fixed linear scale steps instead of automatically generated ones. In my case I had to display ranking table changes over time and there were positions skipped or even half positions displayed depending on the ranking size / max value. I also fixed a typo from the broken commit earlier. |
|
@roben did the tabs / spacing change in the linear scale? It looks like the entire file changed :| It also looks like a really old version of the file. Can you also merge the latest v2.0-dev into your version. It would also be great if you could add documentation for the new option to the markdown files in the docs folder. |
Reformatted scale.linear.js to match original indenting.
Refactored and fixed scale calculation. Added dist files to commit.
|
It was the most recent file from v2.0-dev but I used Netbeans' auto format which had different indentation settings than your default. I have changed and reindented it, the diff is much lighter now. I have also added the built files to the commit just for completeness. Note that I needed to change |
nbproject/private/private.properties
Outdated
| @@ -0,0 +1,2 @@ | |||
| auxiliary.org-netbeans-modules-javascript-karma.config=karma.conf.js | |||
| browser=Chrome.INTEGRATED | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can remove this file and others in the nbproject directory
|
@roben thanks for updated. I added a couple of comments to the diff. Once those are addressed, I'll merge this 😄 |
|
The nbproject folder should't have been committed at all. I'll remove it. Regarding the loop: Before implementing my changes I had issues with the graph ignoring suggestedMin and starting with 0.5 instead of 1 and I was confused by all the rounding going on there. I exit the loop after max has been reached to make sure that the last value has a tick label. But what do you mean with
? I can't see how this loop could fail besides looking really ugly if the step width is set too small. |
|
The case I was thinking of is when |
…x conflicts. Refactored linear scale fixed step size implementation. Added nbproject to .gitignore
|
I have applied the changes and merged your repository to fix the conflicts. |
Fix tooltip error and add fixed steps to linear scale
|
Thanks @roben |
I noticed that using the label callbacks only added all returned contents to a single line in contrast to the documentation: "All functions must return either a string or an array of strings. Arrays of strings are treated as multiple lines of text.". This pull request fixes this.