Generic Rectangle: any border (botton, left, top, right) can be skipped now. #2128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@The-Smallest this looks great. Do you think it be beneficial to also support multiple borders being excluded? |
Contributor
Author
|
Not sure about multiple borders exclusion. (Can't really find use-case for it). |
etimberg
added a commit
that referenced
this pull request
Mar 13, 2016
Generic Rectangle: any border (botton, left, top, right) can be skipped now.
Member
|
Yeah, I couldn't think of a use-case either. Just wanted to make sure everything was covered 😛 Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added 'borderSkipped' parameter to Rectangle, it controls which border to exclude.